cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-7276) Include keyspace and table names in logs where possible
Date Thu, 10 Mar 2016 18:55:40 GMT


Paulo Motta commented on CASSANDRA-7276:

bq. Do we think this approach is what would like to roll with ? We went back and forth a bit
on this, so might be better to agree on the approach first before making the changes (esp
because it touches so many files and requires constant rebasing).

Doing back-and-fort means the solution is improving, so I don't see a problem with this. If
we had a satisfactory solution before than it would've been rolled already. With that said,
I think we shouldn't be making substantial changes in this design in future iterations.

> Include keyspace and table names in logs where possible
> -------------------------------------------------------
>                 Key: CASSANDRA-7276
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Tyler Hobbs
>            Priority: Minor
>              Labels: bootcamp, lhf
>             Fix For: 2.1.x
>         Attachments: 0001-Better-Logging-for-KS-and-CF.patch, 0001-Logging-KS-and-CF-consistently.patch,
0001-Logging-for-Keyspace-and-Tables.patch, 2.1-CASSANDRA-7276-v1.txt, cassandra-2.1-7276-compaction.txt,
cassandra-2.1-7276.txt, cassandra-2.1.9-7276-v2.txt, cassandra-2.1.9-7276.txt
> Most error messages and stacktraces give you no clue as to what keyspace or table was
causing the problem.  For example:
> {noformat}
> ERROR [MutationStage:61648] 2014-05-20 12:05:45,145 (line 198) Exception
in thread Thread[MutationStage:61648,5,main]
> java.lang.IllegalArgumentException
>     at java.nio.Buffer.limit(Unknown Source)
>     at org.apache.cassandra.db.marshal.AbstractCompositeType.getBytes(
>     at org.apache.cassandra.db.marshal.AbstractCompositeType.getWithShortLength(
>     at
>     at
>     at edu.stanford.ppl.concurrent.SnapTreeMap$1.compareTo(
>     at edu.stanford.ppl.concurrent.SnapTreeMap.attemptUpdate(
>     at edu.stanford.ppl.concurrent.SnapTreeMap.updateUnderRoot(
>     at edu.stanford.ppl.concurrent.SnapTreeMap.update(
>     at edu.stanford.ppl.concurrent.SnapTreeMap.putIfAbsent(
>     at org.apache.cassandra.db.AtomicSortedColumns$Holder.addColumn(
>     at org.apache.cassandra.db.AtomicSortedColumns.addAllWithSizeDelta(
>     at org.apache.cassandra.db.Memtable.resolve(
>     at org.apache.cassandra.db.Memtable.put(
>     at org.apache.cassandra.db.ColumnFamilyStore.apply(
>     at org.apache.cassandra.db.Keyspace.apply(
>     at org.apache.cassandra.db.Keyspace.apply(
>     at org.apache.cassandra.db.RowMutation.apply(
>     at org.apache.cassandra.db.RowMutationVerbHandler.doVerb(
>     at
>     at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
>     at java.util.concurrent.ThreadPoolExecutor$ Source)
>     at Source)
> {noformat}
> We should try to include info on the keyspace and column family in the error messages
or logs whenever possible.  This includes reads, writes, compactions, flushes, repairs, and
probably more.

This message was sent by Atlassian JIRA

View raw message