Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 824F518B7F for ; Thu, 11 Feb 2016 04:28:18 +0000 (UTC) Received: (qmail 63084 invoked by uid 500); 11 Feb 2016 04:28:18 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 63051 invoked by uid 500); 11 Feb 2016 04:28:18 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 63040 invoked by uid 99); 11 Feb 2016 04:28:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2016 04:28:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0D5012C0AFA for ; Thu, 11 Feb 2016 04:28:18 +0000 (UTC) Date: Thu, 11 Feb 2016 04:28:18 +0000 (UTC) From: "Stefania (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-11156) AssertionError when listing sstable files on inconsistent disk state MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-11156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142232#comment-15142232 ] Stefania commented on CASSANDRA-11156: -------------------------------------- 3.0 patch is [here|https://github.com/stef1927/cassandra/commits/11156-3.0] and merges cleanly upwards. There is already a unit test capable of covering this code path but it expects an exception thrown when listing files in an inconsistent state and it did not check for assertion errors. Tests: * http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11156-3.0-testall * http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11156-3.0-dtest > AssertionError when listing sstable files on inconsistent disk state > -------------------------------------------------------------------- > > Key: CASSANDRA-11156 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11156 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths > Reporter: Stefania > Assignee: Stefania > Fix For: 3.0.x, 3.x > > > We've had the following failure which, although very hard to reproduce, could happen if we find an inconsistent disk state: > http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-marcuse-11148-trunk-dtest/1/testReport/junit/consistency_test/TestConsistency/readrepair_test_2/ > To fix it we just need to reset the records in {{LogFile}} before reading it again in {{LogFileLister}}: > {code} > // otherwise read the file again to see if it is completed now > readTxnLog(txnFile); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)