cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Olsson (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-11215) Reference leak with parallel repairs on the same table
Date Tue, 23 Feb 2016 14:50:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158981#comment-15158981
] 

Marcus Olsson edited comment on CASSANDRA-11215 at 2/23/16 2:50 PM:
--------------------------------------------------------------------

Patch for 2.2 is available [here|https://github.com/emolsson/cassandra/commit/8b1b4317c43db648d54ce2e339a525e3fb324cab].

I think there will be some merge conflicts in 3.0/3.x should I apply separate patch sets for
them directly or wait for the review of the 2.2 version first?

Edit: To make it clear what the fix is, the sstableCandidates are put in a try-with-resources
to make sure that they are released. I felt that this clarification might be needed since
the patch also moves the SSTable referencing code to a separate method to reduce complexity
in the doValidationCompaction-method.


was (Author: molsson):
Patch for 2.2 is available [here|https://github.com/emolsson/cassandra/commit/8b1b4317c43db648d54ce2e339a525e3fb324cab].

I think there will be some merge conflicts in 3.0/3.x should I apply separate patch sets for
them directly or wait for the review of the 2.2 version first?

> Reference leak with parallel repairs on the same table
> ------------------------------------------------------
>
>                 Key: CASSANDRA-11215
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11215
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Olsson
>            Assignee: Marcus Olsson
>
> When starting multiple repairs on the same table Cassandra starts to log about reference
leak as:
> {noformat}
> ERROR [Reference-Reaper:1] 2016-02-23 15:02:05,516 Ref.java:187 - LEAK DETECTED: a reference
(org.apache.cassandra.utils.concurrent.Ref$State@5213f926) to class org.apache.cassandra.io.sstable.format.SSTableReader
> $InstanceTidier@605893242:.../testrepair/standard1-dcf311a0da3411e5a5c0c1a39c091431/la-30-big
was not released before the reference was garbage collected
> {noformat}
> Reproducible with:
> {noformat}
> ccm create repairtest -v 2.2.5 -n 3
> ccm start
> ccm stress write n=1000000 -schema replication(strategy=SimpleStrategy,factor=3) keyspace=testrepair
> # And then perform two repairs concurrently with:
> ccm node1 nodetool repair testrepair
> {noformat}
> I know that starting multiple repairs in parallel on the same table isn't very wise,
but this shouldn't result in reference leaks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message