cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11148) Remove duplicate offline compaction tracking
Date Thu, 11 Feb 2016 03:46:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142200#comment-15142200
] 

Stefania commented on CASSANDRA-11148:
--------------------------------------

LGTM, +1.

I created two new tickets for the 2 dtest failures that do not occur on trunk since they are
not related to this change: CASSANDRA-11156 and CASSANDRA-11157. I've put you as reviewer
of the first one, it should be a one liner.

> Remove duplicate offline compaction tracking
> --------------------------------------------
>
>                 Key: CASSANDRA-11148
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11148
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 3.x
>
>
> We now keep track of whether an operation is offline in the LifecycleTransaction - also
keeping the isOffline boolean flag around is confusing and error prone.
> Remove isOffline everywhere, but try to keep backwards compatibility as much as possible
since most things related to compaction are public APIs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message