cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11123) cqlsh pg-style-strings broken if line ends with ';'
Date Mon, 08 Feb 2016 01:26:40 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136549#comment-15136549
] 

Stefania commented on CASSANDRA-11123:
--------------------------------------

The functionality seems correct, I tested it manually on Linux and it works as expected. As
far as I understood from CASSANDRA-7769, we only support {{$$}} and we don't therefore support
embedded pg-style-strings.

Two things:

* {{cql_split_statements}} is called by the cqlshlib tests as well, see {{test_cqlsh_parsing.py}}
and {{casconnect.py}}. As a result, a number of cqlshlib tests are broken. To run these tests
start up a cassandra node with a clean data folder, go into {{pylib/cqlshlib/test}} and type
{{nosetests}}.
* IMO we don't need to return two different boolean values from {{cql_split_statements}} as
they convey the same information as far as the callers are concerned, that is to continue
parsing, so maybe only use one boolean with an appropriate name?

> cqlsh pg-style-strings broken if line ends with ';'
> ---------------------------------------------------
>
>                 Key: CASSANDRA-11123
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11123
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Minor
>             Fix For: 2.2.x
>
>
> If one separate line in a multi-line pg-style-string ends with a semicolon in cqlsh,
cqlsh incorrectly assumes that that is the end of the statement.
> {code}
> cqlsh:foo> insert into tab (pk, val) values (2, $$
>        ... wepofjef
>        ... wefoijew
>        ... ;
> SyntaxException: <ErrorMessage code=2000 [Syntax error in CQL query] message="line
4:0 mismatched character ';' expecting '$'">
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message