cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10733) Inconsistencies in CQLSH auto-complete
Date Thu, 11 Feb 2016 19:52:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143374#comment-15143374
] 

Tyler Hobbs commented on CASSANDRA-10733:
-----------------------------------------

Great, thank you for the tests!  I've made some minor cleanups and started the CI test runs
here:

||branch||dtest||
|[CASSANDRA-10733|https://github.com/thobbs/cassandra/tree/CASSANDRA-10733]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10733-dtest]|
|[CASSANDRA-10733-3.0|https://github.com/thobbs/cassandra/tree/CASSANDRA-10733-3.0]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10733-3.0-dtest]|
|[CASSANDRA-10733-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-10733-trunk]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10733-trunk-dtest]|

I only triggered dtests, since this change only affects cqlsh.

> Inconsistencies in CQLSH auto-complete
> --------------------------------------
>
>                 Key: CASSANDRA-10733
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10733
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL, Tools
>            Reporter: Michael Edge
>            Assignee: Michael Edge
>            Priority: Trivial
>              Labels: cqlsh, lhf
>             Fix For: 2.2.x, 3.x
>
>         Attachments: 10733-fix-space-2.2.txt, CASSANDRA-2.2-10733-CQLSH-Auto.patch, CASSANDRA-2.2-10733-tests.patch,
CASSANDRA-3.0-10733-CQLSH-Auto.patch
>
>
> Auto-complete in cqlsh does not work correctly on some commands. We see some inconsistent
behaviour when completing part of the statement and hitting the tab key.
> {color:green}Works correctly{color}
> Auto-complete on {{'desc table '}}, {{'desc function '}} and {{'desc type '}} works correctly.
We see a list of all tables (or functions, types) in the current keyspace plus a list of all
available keyspaces followed by a full stop (e.g. system.)
> {code}
> cqlsh:fxaggr> desc TABLE 
>                      minutedata           system_distributed.
> ;                    rawtickdatabylp      system_traces.
> <enter>              rawtickdatabysymbol  tickdata
> daydata              system.              
> fxaggr.              system_auth.     
> {code}
> {color:red}Fix required{color}
> {{'desc aggregate '}} displays the aggregates in the current keyspace (in this case,
only 1, called 'average') but does not display a list of available keyspaces. It only displays
the current keyspace, with no following full stop.
> {code}
> cqlsh:fxaggr> desc aggregate 
>          ;        <enter>  average  fxaggr
> {code}
> {color:green}Works correctly{color}
> Auto-complete on {{'desc table <keyspace>. '}} and {{'desc type <keyspace>.'}}
works correctly. We see a list of all tables (or types) in the current keyspace
> {code}
> cqlsh:fxaggr> desc table fxaggr.
> daydata              rawtickdatabylp      tickdata
> minutedata           rawtickdatabysymbol  
> {code}
> {color:red}Fix required{color}
> Auto-complete on {{'desc function <keyspace>. '}} and {{'desc aggregate <keyspace>.'}}
works inconsistently. In a keyspace with 2 functions, both beginning with the letters 'avg',
if I type {{'desc function <keyspace>'}} and hit tab, auto-complete will result in this:
{{'desc function fxaggr.avg '}} and will not display the matching functions. If I type {{'desc
function <keyspace>.'}} (note the trailing full stop) and hit tab, auto-complete will
work correctly:
> {code}
> cqlsh:fxaggr> desc function fxaggr.avg
> avgfinal  avgstate  
> {code}
> If I type {{'desc aggregate <keyspace>'}} and hit tab, auto-complete returns  {{'desc
aggregate <keyspace> '}}  (it adds a space) and does not show me the list of available
aggregates. If I type {{'desc aggregate <keyspace>.'}} (note the trailing full stop)
and hit tab, auto-complete will work correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message