cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-10273) Reduce number of data directory scans during startup
Date Mon, 15 Feb 2016 06:42:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146971#comment-15146971
] 

Jeff Jirsa edited comment on CASSANDRA-10273 at 2/15/16 6:42 AM:
-----------------------------------------------------------------

Hi [~alextkaiser],

I suspect the pre-flight sstable min version check he's referencing are in [o/a/c/service/StartupChecks.java|https://github.com/apache/cassandra/blob/ee5aec2d2ed7795d64a052e191af4aec5c807dba/src/java/org/apache/cassandra/service/StartupChecks.java#L228-L282]
and scrub in [o/a/c/service/CassandraDaemon.java|https://github.com/apache/cassandra/blob/ee5aec2d2ed7795d64a052e191af4aec5c807dba/src/java/org/apache/cassandra/service/CassandraDaemon.java#L239]



On a tangent, calling what [ColumnFamilyStore is doing on startup|https://github.com/apache/cassandra/blob/ee5aec2d2ed7795d64a052e191af4aec5c807dba/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L580-L584]
{{scrub}} seems like dangerous overloading of that term, given that cassandra has a {{scrubber}}
that does something very, very different.



was (Author: jjirsa):
Hi [~alextkaiser],

I suspect the pre-flight sstable min version check he's referencing are in [o/a/c/service/StartupChecks.java|https://github.com/apache/cassandra/blob/ee5aec2d2ed7795d64a052e191af4aec5c807dba/src/java/org/apache/cassandra/service/StartupChecks.java#L228-L282]
and scrub in [o/a/c/service/CassandraDaemon.java|https://github.com/apache/cassandra/blob/ee5aec2d2ed7795d64a052e191af4aec5c807dba/src/java/org/apache/cassandra/service/CassandraDaemon.java#L239]





> Reduce number of data directory scans during startup
> ----------------------------------------------------
>
>                 Key: CASSANDRA-10273
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10273
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Robert Stupp
>            Priority: Minor
>              Labels: lhf
>
> ATM we scan each data directory four times. We could easily reduce that to at least two,
maybe to one.
> 1. pre-flight (startup tests) scrub
> 1. pre-flight (startup tests) sstable min version
> 1. {{ColumnFamilyStore.createColumnFamilyStore}}
> 1. {{ColumnFamilyStore.<init>}} (if {{loadSSTables==true}})
> First two pre-flight tests could be combined to one and 3+4 could also be combined, as
both appear at pretty related code paths.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message