cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anubhav Kale (JIRA)" <>
Subject [jira] [Updated] (CASSANDRA-7276) Include keyspace and table names in logs where possible
Date Mon, 08 Feb 2016 23:57:40 GMT


Anubhav Kale updated CASSANDRA-7276:
    Attachment: 0001-Better-Logging-for-KS-CF.patch

Attached first cut of this.

With current approach, I have omitted BatchLog*VerbHandler and Repair*VerbHandler since they
operate on Collection of mutations. This would mean we change the interface to collection
of KS, instead of just the KS as originally suggested. We can do that, but we may lose the
goal we are after here if MessageDeliveryTask simply prints a collection of KS and CF when
something goes wrong. 

I took a stab at manually updating log stmts in KFS and CompactionManager. We can add logs
in other places later once this first pass is committed (to keep merges sane).

Also, there is a possibility of introducing a base class for IKeyspaceAwareVerbHandler but
I did not do that for readability sake (else the tree starts getting too deep).

In logs, should we use KS and CF or Keyspace and Table ? I don't believe there is a consistent
pattern as such.

> Include keyspace and table names in logs where possible
> -------------------------------------------------------
>                 Key: CASSANDRA-7276
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Tyler Hobbs
>            Priority: Minor
>              Labels: bootcamp, lhf
>             Fix For: 2.1.x
>         Attachments: 0001-Better-Logging-for-KS-CF.patch, 2.1-CASSANDRA-7276-v1.txt,
cassandra-2.1-7276-compaction.txt, cassandra-2.1-7276.txt, cassandra-2.1.9-7276-v2.txt, cassandra-2.1.9-7276.txt
> Most error messages and stacktraces give you no clue as to what keyspace or table was
causing the problem.  For example:
> {noformat}
> ERROR [MutationStage:61648] 2014-05-20 12:05:45,145 (line 198) Exception
in thread Thread[MutationStage:61648,5,main]
> java.lang.IllegalArgumentException
>     at java.nio.Buffer.limit(Unknown Source)
>     at org.apache.cassandra.db.marshal.AbstractCompositeType.getBytes(
>     at org.apache.cassandra.db.marshal.AbstractCompositeType.getWithShortLength(
>     at
>     at
>     at edu.stanford.ppl.concurrent.SnapTreeMap$1.compareTo(
>     at edu.stanford.ppl.concurrent.SnapTreeMap.attemptUpdate(
>     at edu.stanford.ppl.concurrent.SnapTreeMap.updateUnderRoot(
>     at edu.stanford.ppl.concurrent.SnapTreeMap.update(
>     at edu.stanford.ppl.concurrent.SnapTreeMap.putIfAbsent(
>     at org.apache.cassandra.db.AtomicSortedColumns$Holder.addColumn(
>     at org.apache.cassandra.db.AtomicSortedColumns.addAllWithSizeDelta(
>     at org.apache.cassandra.db.Memtable.resolve(
>     at org.apache.cassandra.db.Memtable.put(
>     at org.apache.cassandra.db.ColumnFamilyStore.apply(
>     at org.apache.cassandra.db.Keyspace.apply(
>     at org.apache.cassandra.db.Keyspace.apply(
>     at org.apache.cassandra.db.RowMutation.apply(
>     at org.apache.cassandra.db.RowMutationVerbHandler.doVerb(
>     at
>     at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
>     at java.util.concurrent.ThreadPoolExecutor$ Source)
>     at Source)
> {noformat}
> We should try to include info on the keyspace and column family in the error messages
or logs whenever possible.  This includes reads, writes, compactions, flushes, repairs, and
probably more.

This message was sent by Atlassian JIRA

View raw message