Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3EE8418E92 for ; Fri, 8 Jan 2016 18:37:40 +0000 (UTC) Received: (qmail 50645 invoked by uid 500); 8 Jan 2016 18:37:40 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 50609 invoked by uid 500); 8 Jan 2016 18:37:40 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 50595 invoked by uid 99); 8 Jan 2016 18:37:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 18:37:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C9C262C1F58 for ; Fri, 8 Jan 2016 18:37:39 +0000 (UTC) Date: Fri, 8 Jan 2016 18:37:39 +0000 (UTC) From: "Aleksey Yeschenko (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10940) sstableloader shuold skip streaming SSTable generated in < 3.0.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089660#comment-15089660 ] Aleksey Yeschenko commented on CASSANDRA-10940: ----------------------------------------------- I think we should first find a valid reason for that, and I doubt there is one. In order of my preferences: 1. Fix streaming to restore the ability to stream older sstables 2. Error out in the beginning with {{upgradesstables}} instructions, until 1) is done > sstableloader shuold skip streaming SSTable generated in < 3.0.0 > ---------------------------------------------------------------- > > Key: CASSANDRA-10940 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10940 > Project: Cassandra > Issue Type: Bug > Components: Streaming and Messaging, Tools > Reporter: Yuki Morishita > Assignee: Yuki Morishita > Priority: Minor > Fix For: 3.0.x, 3.x > > > Since 3.0.0, [streaming does not support SSTable from version less than 3.0.0|https://github.com/apache/cassandra/blob/0f5e780781ce3f0cb3732515dacc7e467571a7c9/src/java/org/apache/cassandra/io/sstable/SSTableSimpleIterator.java#L116]. > {{sstableloader}} should skip those files to be streamed, instead of erroring out like below: > {code} > Failed to list files in /home/yuki/.ccm/2.1.11/node1/data/keyspace1/standard1-5242ae50a9b311e585b29dc952593398 > java.lang.NullPointerException > java.lang.RuntimeException: Failed to list files in /home/yuki/.ccm/2.1.11/node1/data/keyspace1/standard1-5242ae50a9b311e585b29dc952593398 > at org.apache.cassandra.db.lifecycle.LogAwareFileLister.list(LogAwareFileLister.java:53) > at org.apache.cassandra.db.lifecycle.LifecycleTransaction.getFiles(LifecycleTransaction.java:544) > at org.apache.cassandra.io.sstable.SSTableLoader.openSSTables(SSTableLoader.java:76) > at org.apache.cassandra.io.sstable.SSTableLoader.stream(SSTableLoader.java:165) > at org.apache.cassandra.tools.BulkLoader.main(BulkLoader.java:101) > Caused by: java.lang.NullPointerException > at org.apache.cassandra.io.sstable.format.SSTableReader.openForBatch(SSTableReader.java:421) > at org.apache.cassandra.io.sstable.SSTableLoader.lambda$openSSTables$186(SSTableLoader.java:121) > at org.apache.cassandra.io.sstable.SSTableLoader$$Lambda$18/712974096.apply(Unknown Source) > at org.apache.cassandra.db.lifecycle.LogAwareFileLister.lambda$innerList$178(LogAwareFileLister.java:75) > at org.apache.cassandra.db.lifecycle.LogAwareFileLister$$Lambda$29/1191654595.test(Unknown Source) > at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174) > at java.util.TreeMap$EntrySpliterator.forEachRemaining(TreeMap.java:2965) > at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:512) > at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:502) > at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708) > at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) > at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499) > at org.apache.cassandra.db.lifecycle.LogAwareFileLister.innerList(LogAwareFileLister.java:77) > at org.apache.cassandra.db.lifecycle.LogAwareFileLister.list(LogAwareFileLister.java:49) > ... 4 more > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)