cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11003) cqlsh.py: Shell instance has no attribute 'parse_for_table_meta'
Date Fri, 22 Jan 2016 21:54:39 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113176#comment-15113176
] 

Tyler Hobbs commented on CASSANDRA-11003:
-----------------------------------------

Thanks for the patch!  Your fix is fine, but I actually prefer the name {{parse_for_update_meta}},
because it clearly serves a different purpose than {{parse_for_select_meta}}, so I've used
that name.

By the way, this only affects LWT inserts and updates.  I'll edit the title to reflect that.

I have created a new dtest to cover this: https://github.com/riptano/cassandra-dtest/pull/768

Branch and pending CI runs:
||branch||testall||dtest||
|[CASSANDRA-11003|https://github.com/thobbs/cassandra/tree/CASSANDRA-11003]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11003-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11003-dtest]|
|[CASSANDRA-11003-3.3|https://github.com/thobbs/cassandra/tree/CASSANDRA-11003-3.3]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11003-3.3-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11003-3.3-dtest]|
|[CASSANDRA-11003-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-11003-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11003-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11003-trunk-dtest]|

> cqlsh.py: Shell instance has no attribute 'parse_for_table_meta'
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-11003
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11003
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Eduard Tudenhoefner
>            Assignee: Eduard Tudenhoefner
>             Fix For: 3.0.x, 3.x
>
>         Attachments: 11003-cassandra-3.0.txt
>
>
> {code}
> $ cqlsh -u cassandra -p cassandra
> Connected to abc at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 3.0.1.816 | DSE 5.0.0 | CQL spec 3.4.0 | Native protocol v4]
> Use HELP for help.
> cassandra@cqlsh> SOME COMMAND;
> Shell instance has no attribute 'parse_for_table_meta'
> {code}
> I think this is happening because of a bad merge (https://github.com/apache/cassandra/commit/2800bf1082e773daf0af29516b61c711acda626b#diff-1cce67f7d76864f07aaf4d986d6fc051).
We just need to rename *parse_for_update_meta* to *parse_for_table_meta*



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message