cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10924) Pass base table's metadata to Index.validateOptions
Date Fri, 08 Jan 2016 17:55:39 GMT


Sam Tunnicliffe commented on CASSANDRA-10924:

Hmm, yes I can see how that may make validation tricky for some custom implementations. The
problem is with changing the method signature in a non-major version. I know it will complicate
{{IndexMetadata}} somewhat, but could we extend the check to look for both signatures and
call whichever is defined? 

> Pass base table's metadata to Index.validateOptions
> ---------------------------------------------------
>                 Key: CASSANDRA-10924
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL, Local Write-Read Paths
>            Reporter: Andrés de la Peña
>            Assignee: Andrés de la Peña
>            Priority: Minor
>              Labels: 2i, index, validation
>             Fix For: 3.0.x, 3.x
>         Attachments: CASSANDRA-10924-v0.diff
> Some custom index implementations require the base table's metadata to validate their
creation options. For example, the options of these implementations can contain information
about which base table's columns are going to be indexed and how, so the implementation needs
to know the existence and the type of the columns to be indexed to properly validate.
> The attached patch proposes to add base table's {{CFMetaData}} to Index' optional static
method to validate the custom index options:
> {{public static Map<String, String> validateOptions(CFMetaData cfm, Map<String,
String> options);}}

This message was sent by Atlassian JIRA

View raw message