cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10907) Nodetool snapshot should provide an option to skip flushing
Date Tue, 19 Jan 2016 20:13:39 GMT


Paulo Motta commented on CASSANDRA-10907:

Looking better. A few more nits:
* Rename {{skipflush}} option to {{skipFlush}} (camelCase)
* remove skipFlush from takeMultipleTableSnapshot javadoc
* add @Deprecated annotation to old methods (in addition to @deprecated javadoc)
* in javadoc {{@link #takeSnapshot..}} replace {{Map<String,String>}} with {{Map}} (generics
is not supported in javadoc link)
* Add options to message: {{Requested creating snapshot(s) for \[keyspace1.standard1,keyspace1.counter1\]
with snapshot name \[1453233210025\] and options \{skipFlush=false\}.}}
* Fix broken test {{org.apache.cassandra.service.StorageServiceServerTest.testTableSnapshot}}
* Improve nodetool option description from {{Skip blocking flush of the memtable}} to {{Do
not flush memtables before snapshotting (snapshot will not contain unflushed data)}}

bq. I did add a Boolean to detect if KS / CF was passed to the proposed signature to make
things easy. 

I still find it a bit redudant, since it's possible to replace the keyspaces boolean with
{{entities\[0\].contains(".")}}, and in the future we can simplify the snapshot command to
accept an arbitrary list of mixed keyspaces and/or tables, so I'd prefer to not have this


> Nodetool snapshot should provide an option to skip flushing
> -----------------------------------------------------------
>                 Key: CASSANDRA-10907
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Configuration
>         Environment: PROD
>            Reporter: Anubhav Kale
>            Priority: Minor
>              Labels: lhf
>         Attachments: 0001-Skip-Flush-for-snapshots.patch, 0001-Skip-Flush-option-for-Snapshot.patch,
> For some practical scenarios, it doesn't matter if the data is flushed to disk before
taking a snapshot. However, it's better to save some flushing time to make snapshot process
> As such, it will be a good idea to provide this option to snapshot command. The wiring
from nodetool to MBean to VerbHandler should be easy. 
> I can provide a patch if this makes sense.

This message was sent by Atlassian JIRA

View raw message