cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10902) Skip saved cache directory when checking SSTables at startup
Date Mon, 04 Jan 2016 17:41:39 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081439#comment-15081439
] 

Sam Tunnicliffe commented on CASSANDRA-10902:
---------------------------------------------

There's a corner case which these patches don't cover. Namely, if {{data_file_directories}}
isn't set then the {{dir}} argument to {{preVisitDirectory}} is relative to {{bin}} and so
the {{Path}} comparisons don't hold. 

Also, in the 3.0 & trunk branches, {{Directories.SNAPSHOT_SUBDIR}} is referenced twice
in {{preVisitDirectory}}, where the second time it should be {{Directories.BACKUP_SUBDIR}}

I've pushed branches with fixes for both issues, do they look reasonable to you [~carlyeks]
?

||2.2||3.0||
|[branch|https://github.com/beobal/cassandra/tree/10902-2.2]|[branch|https://github.com/beobal/cassandra/tree/10902-3.0]|
|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10902-2.2-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10902-3.0-testall/]|
|[dtests|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10902-2.2-dtest/]|[dtests|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10902-3.0-dtest/]|


> Skip saved cache directory when checking SSTables at startup
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-10902
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10902
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Configuration
>            Reporter: Carl Yeksigian
>            Assignee: Carl Yeksigian
>             Fix For: 2.2.x, 3.0.x, 3.x
>
>
> The SSTable StartupCheck looks for all files which end with "*.db" and compares the version.
This causes problems if {{saved_cache_directory}} is a subdirectory of a {{data_file_directories}}.
We should make sure that we are not checking any subdirectory where we might be writing *.db
files.
> This is the cause of not being able to restart in CASSANDRA-10821.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message