Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 23 Dec 2015 17:58:46 +0000 (UTC)
From: "Robert Stupp (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12923638.1450749573000.103764.1450893526653@Atlassian.JIRA>
In-Reply-To: <JIRA.12923638.1450749573000@Atlassian.JIRA>
References: <JIRA.12923638.1450749573000@Atlassian.JIRA>
 <JIRA.12923638.1450749573592@arcas>
Subject: [jira] [Commented] (CASSANDRA-10917) better validator randomness
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-10917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069966#comment-15069966 ] 

Robert Stupp commented on CASSANDRA-10917:
------------------------------------------

+1 on the change.

One nit: {{keys.clear()}} could be moved up into the else branch


> better validator randomness
> ---------------------------
>
>                 Key: CASSANDRA-10917
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10917
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local Write-Read Paths
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 3.x
>
>         Attachments: 10917.txt
>
>
> get better randomness by reusing a Random object rather than recreating it.
> Also reuse keys list to avoid reallocations.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)