Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 2 Dec 2015 15:13:11 +0000 (UTC)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12915549.1448309600000.246383.1449069191193@Atlassian.JIRA>
In-Reply-To: <JIRA.12915549.1448309600000@Atlassian.JIRA>
References: <JIRA.12915549.1448309600000@Atlassian.JIRA>
 <JIRA.12915549.1448309600053@arcas>
Subject: [jira] [Commented] (CASSANDRA-10761) Possible regression of
 CASSANDRA-9201
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-10761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035936#comment-15035936 ] 

Sylvain Lebresne commented on CASSANDRA-10761:
----------------------------------------------

A few small remarks (that really only apply to 3.0):
# While this is not a problem of this patch, I don't think {{Schema.load}} should be called first as it is. It populates {{cfIdMap}} which intrinsically points to the {{keyspaces}} map, so it doesn't make sense to do that before we've even added the new table to {{keyspaces}} (which should itself come after initialization).
# Not a fan of doing the working in the closure passed to {{Schema.update}}: that closure is fundamentally a tranformation of its {{KeyspaceMetadata}} argument and doing side effect in it should be avoided as it adds nothing. I'll note that this is also not new to this patch.
# We should modify {{Schema.addView}} in a similar way.

To clarify what I have in mind, I've pushed changes for those remarks [here|https://github.com/pcmanus/cassandra/commits/10761-3.0]. With those changes I'm +1 on the rest, so if you agree on said changes, would you mind pulling them in your branches and checking CI before committing?


> Possible regression of CASSANDRA-9201
> -------------------------------------
>
>                 Key: CASSANDRA-10761
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10761
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Philip Thompson
>            Assignee: Sam Tunnicliffe
>             Fix For: 3.0.1, 3.1, 2.2.x
>
>         Attachments: 10761-logs.tar.gz
>
>
> Some dtests like {{consistency_test.TestAccuracy.test_network_topology_strategy_each_quorum_counters}} are failing with the follow auth related assertion exception
> {code}
> [node6 ERROR] java.lang.AssertionError: org.apache.cassandra.exceptions.InvalidRequestException: unconfigured table roles
> 	at org.apache.cassandra.auth.CassandraRoleManager.prepare(CassandraRoleManager.java:450)
> 	at org.apache.cassandra.auth.CassandraRoleManager.setup(CassandraRoleManager.java:144)
> 	at org.apache.cassandra.service.StorageService.doAuthSetup(StorageService.java:1036)
> 	at org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:984)
> 	at org.apache.cassandra.service.StorageService.initServer(StorageService.java:708)
> 	at org.apache.cassandra.service.StorageService.initServer(StorageService.java:579)
> 	at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:345)
> 	at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:561)
> 	at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:689)
> Caused by: org.apache.cassandra.exceptions.InvalidRequestException: unconfigured table roles
> 	at org.apache.cassandra.thrift.ThriftValidation.validateColumnFamily(ThriftValidation.java:114)
> 	at org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:757)
> 	at org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:752)
> 	at org.apache.cassandra.auth.CassandraRoleManager.prepare(CassandraRoleManager.java:446)
> 	... 8 more
> {code}
> This looks very similar to CASSANDRA-9201.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)