Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 61F901809E for ; Wed, 2 Dec 2015 16:56:25 +0000 (UTC) Received: (qmail 19559 invoked by uid 500); 2 Dec 2015 16:56:11 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 19238 invoked by uid 500); 2 Dec 2015 16:56:11 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 19123 invoked by uid 99); 2 Dec 2015 16:56:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Dec 2015 16:56:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0A12D2C1F72 for ; Wed, 2 Dec 2015 16:56:11 +0000 (UTC) Date: Wed, 2 Dec 2015 16:56:11 +0000 (UTC) From: "Ivan Burmistrov (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10585) SSTablesPerReadHistogram seems wrong when row cache hit happend MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036122#comment-15036122 ] Ivan Burmistrov commented on CASSANDRA-10585: --------------------------------------------- I've attached patch for trunk (and it works for 3.0 too). > SSTablesPerReadHistogram seems wrong when row cache hit happend > --------------------------------------------------------------- > > Key: CASSANDRA-10585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10585 > Project: Cassandra > Issue Type: Bug > Reporter: Ivan Burmistrov > Assignee: Ivan Burmistrov > Priority: Minor > Fix For: 2.1.x, 2.2.x, 3.0.x > > Attachments: SSTablePerReadHistogram_RowCache-cassandra-2_1.patch, SSTablePerReadHistogram_RowCache-cassandra-2_2.patch, SSTablePerReadHistogram_RowCache_trunk.patch > > > SSTablePerReadHistogram metric now not considers case when row has been read from row cache. > And so, this metric will have big values even almost all requests processed by row cache (and without touching SSTables, of course). > So, it seems that correct behavior is to consider that if we read row from row cache then we read zero SSTables by this request. > The patch at the attachment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)