Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B20A618E8C for ; Fri, 4 Dec 2015 22:16:14 +0000 (UTC) Received: (qmail 82936 invoked by uid 500); 4 Dec 2015 22:16:11 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 82905 invoked by uid 500); 4 Dec 2015 22:16:11 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 82891 invoked by uid 99); 4 Dec 2015 22:16:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Dec 2015 22:16:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F35C22C1F70 for ; Fri, 4 Dec 2015 22:16:10 +0000 (UTC) Date: Fri, 4 Dec 2015 22:16:10 +0000 (UTC) From: "Paulo Motta (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10580) On dropped mutations, more details should be logged. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042324#comment-15042324 ] Paulo Motta commented on CASSANDRA-10580: ----------------------------------------- Thanks for the patch. Can you please rebase/merge to latest 2.1 HEAD? Some comments: - use debug level instead of warn in order not to pollute system.log, and not to scare away users, since dropping mutations is part of the normal load shedding mechanism. In 2.2 all debug level logging will go to debug.log file. - print only keyspace and table name, as logging the whole mutation might reveal sensitive information in logs > On dropped mutations, more details should be logged. > ---------------------------------------------------- > > Key: CASSANDRA-10580 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10580 > Project: Cassandra > Issue Type: Improvement > Components: Coordination > Environment: Production > Reporter: Anubhav Kale > Assignee: Anubhav Kale > Priority: Minor > Fix For: 2.1.x > > Attachments: CASSANDRA-10580-Head.patch > > > In our production cluster, we are seeing a large number of dropped mutations. At a minimum, we should print the time the thread took to get scheduled thereby dropping the mutation (We should also print the Message / Mutation so it helps in figuring out which column family was affected). This will help find the right tuning parameter for write_timeout_in_ms. > The change is small and is in StorageProxy.java and MessagingTask.java. I will submit a patch shortly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)