cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10917) better validator randomness
Date Wed, 23 Dec 2015 17:58:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069966#comment-15069966
] 

Robert Stupp commented on CASSANDRA-10917:
------------------------------------------

+1 on the change.

One nit: {{keys.clear()}} could be moved up into the else branch


> better validator randomness
> ---------------------------
>
>                 Key: CASSANDRA-10917
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10917
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local Write-Read Paths
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 3.x
>
>         Attachments: 10917.txt
>
>
> get better randomness by reusing a Random object rather than recreating it.
> Also reuse keys list to avoid reallocations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message