cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10799) 2 cqlshlib tests still failing with cythonized driver installation
Date Fri, 04 Dec 2015 13:11:10 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041536#comment-15041536
] 

Stefania commented on CASSANDRA-10799:
--------------------------------------

I've adapted the cqlshlib tests to always use the embedded driver even when there is a driver
installed. Two things to note:

* Because the location of the lib folder containing the driver zip file is calculated as relative
to {{__file__}}, the soft link created was causing problems and so I got rid of it. The reason
for this soft link was exclusively for importing cqlsh and since the renaming to cqlsh.py
in 2.2 this is no longer necessary. However in 2.1 we cannot get rid of a soft link (or copy)
unless we rename cqlsh to cqlsh.py and therefore I did not fix 2.1.

* If running the tests from _pylib/cqlshlib_, like we don on Jenkins, _cqlshlib_ is added
to {{sys.path}} and this caused an error when importing {{cassandra.Cluster}} due to a conflict
between the python copy module and _cqlshlib/copy.py_. This is a serious problem and I fixed
it in 2.1 as well. The only reason we don't notice when running cqlsh is that we import {{cassandra.Cluster}}
after adding cqlshlib to {{sys.path}}.

Patches and CI:

||2.1||2.2||3.0||
|[patch|https://github.com/stef1927/cassandra/commits/10799-2.1]|[patch|https://github.com/stef1927/cassandra/commits/10799-2.2]|[patch|https://github.com/stef1927/cassandra/commits/10799-3.0]|
|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10799-2.1-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10799-2.2-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10799-3.0-testall/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10799-2.1-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10799-2.2-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10799-3.0-dtest/]|

2.2 applied cleanly to 3.0 and so I did not create the patches for 3.1 and trunk but I can
do so after review is completed.


> 2 cqlshlib tests still failing with cythonized driver installation
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-10799
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10799
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Stefania
>            Assignee: Stefania
>             Fix For: 2.2.x, 3.x
>
>
> We still have 2 cqlshlib tests failing on Jenkins:
> http://cassci.datastax.com/job/cassandra-3.0_cqlshlib/lastCompletedBuild/testReport/
> Locally, these tests only fail with a cythonized driver installation. If the driver is
not cythonized (installed with {{--no_extensions}}) then the tests are fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message