cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Witschey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10774) Fail stream session if receiver cannot process data
Date Thu, 03 Dec 2015 15:43:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037952#comment-15037952
] 

Jim Witschey commented on CASSANDRA-10774:
------------------------------------------

As Sylvain mentioned here:

https://issues.apache.org/jira/browse/CASSANDRA-10803?focusedCommentId=15037533&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15037533

these changes may be causing dtests to hang on CassCI.

> Fail stream session if receiver cannot process data
> ---------------------------------------------------
>
>                 Key: CASSANDRA-10774
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10774
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Streaming and Messaging
>            Reporter: Paulo Motta
>            Assignee: Paulo Motta
>            Priority: Critical
>             Fix For: 2.1.12, 2.2.4, 3.0.1, 3.1
>
>
> [~tjake] on CASSANDRA-10674:
> {quote}
> I think the underlying issue here is streaming failures only account for problems during
the file send. Not any subsequent errors.
> We should probably add an acknowledgement to the streaming operation that it was processed
by the receiver correctly.
> {quote}
> It seems the stream receive task (and thus the stream sesssion) is only completed on
[2.1|https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java#L175]
and [2.2|https://github.com/apache/cassandra/blob/cassandra-2.2/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java#L171]
after the files are processed (otherwise it just hangs), but on [3.0|https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/streaming/StreamReceiveTask.java#L231]
it's always completed even if there was a failure, what seems more critical. In any case,
we should probably fail the stream session if there is a problem while processing the received
data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message