cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10750) Minor code improvements
Date Tue, 15 Dec 2015 08:33:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057618#comment-15057618
] 

Robert Stupp commented on CASSANDRA-10750:
------------------------------------------

Yea - {{Stack.java}} produced NPEs because the order of the constants (static final fields)
was wrong.
After that fix, both utests and dtests look ok - i.e. there are "just" timeouts in the dtests
similar to current trunk.

> Minor code improvements
> -----------------------
>
>                 Key: CASSANDRA-10750
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10750
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Minor
>
> Went though several IDE inspections and found some places in the code that could be improved.
These are just minor improvements and no bug fixes (except one minor "theoretical" thing).
> The [branch on github against trunk|https://github.com/snazy/cassandra/tree/10750-code-opts-trunk]
contains a series of commits:
> * simplify Mutation.apply to remove the casts
> * "minor code improvements" just replaces some expressions that are effectively constant
> * remove unused assignments (probably just cosmetic)
> * collapse identical if-branches (probably just cosmetic)
> * empty array constants
> * fix printf usage (could potentially raise an exception in printf)
> * replace tail-recursion in some critical sections (as the JVM cannot optimize that AFAIK)
> * remove methods identical to their super methods (probably just cosmetic)
> [cassci results here|http://cassci.datastax.com/view/Dev/view/snazy/search/?q=snazy-10750-]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message