cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10750) Minor code improvements
Date Mon, 14 Dec 2015 15:54:46 GMT


Stefania commented on CASSANDRA-10750:

[~snazy] : I have just started working on the review and I hope to have some more comments
by tomorrow. In the meantime you may want to rebase and take a look at the cassci results
as they don't look too good. Aside from the usual dtests time outs, there seems to be some
NPEs. The utests also had a bad run, at a minimum run them one more time to make sure the
additional time outs are unrelated.

> Minor code improvements
> -----------------------
>                 Key: CASSANDRA-10750
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Minor
> Went though several IDE inspections and found some places in the code that could be improved.
These are just minor improvements and no bug fixes (except one minor "theoretical" thing).
> The [branch on github against trunk|]
contains a series of commits:
> * simplify Mutation.apply to remove the casts
> * "minor code improvements" just replaces some expressions that are effectively constant
> * remove unused assignments (probably just cosmetic)
> * collapse identical if-branches (probably just cosmetic)
> * empty array constants
> * fix printf usage (could potentially raise an exception in printf)
> * replace tail-recursion in some critical sections (as the JVM cannot optimize that AFAIK)
> * remove methods identical to their super methods (probably just cosmetic)
> [cassci results here|]

This message was sent by Atlassian JIRA

View raw message