cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10580) On dropped mutations, more details should be logged.
Date Wed, 16 Dec 2015 14:50:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060077#comment-15060077
] 

Paulo Motta commented on CASSANDRA-10580:
-----------------------------------------

The 2.2 patch does not apply:

{noformat}
➜  cassandra git:(2.2-10580) ✗ git am 2.2-All-Comments.patch
Applying: Patch
error: src/java/org/apache/cassandra/db/ReadCommandVerbHandler.java: does not exist in index
error: patch failed: src/java/org/apache/cassandra/net/MessageDeliveryTask.java:44
error: src/java/org/apache/cassandra/net/MessageDeliveryTask.java: patch does not apply
error: patch failed: src/java/org/apache/cassandra/net/MessagingService.java:957
error: src/java/org/apache/cassandra/net/MessagingService.java: patch does not apply
error: patch failed: src/java/org/apache/cassandra/service/StorageProxy.java:1732
error: src/java/org/apache/cassandra/service/StorageProxy.java: patch does not apply
Patch failed at 0001 Patch
The copy of the patch that failed is found in:
   /home/paulo/Workspace/cassandra/cassandra/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
{noformat}

Trunk patch LGTM, submitted CI tests:

||trunk||
|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-10580]|
|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-10580-testall/lastCompletedBuild/testReport/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-10580-dtest/lastCompletedBuild/testReport/]|


> On dropped mutations, more details should be logged.
> ----------------------------------------------------
>
>                 Key: CASSANDRA-10580
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10580
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Coordination
>         Environment: Production
>            Reporter: Anubhav Kale
>            Assignee: Anubhav Kale
>            Priority: Minor
>             Fix For: 3.2, 2.2.x
>
>         Attachments: 0001-Metrics.patch, 10580-Metrics.patch, 10580.patch, 2.2-All-Comments.patch,
CASSANDRA-10580-Head.patch, Trunk-All-Comments.patch, Trunk.patch
>
>
> In our production cluster, we are seeing a large number of dropped mutations. At a minimum,
we should print the time the thread took to get scheduled thereby dropping the mutation (We
should also print the Message / Mutation so it helps in figuring out which column family was
affected). This will help find the right tuning parameter for write_timeout_in_ms. 
> The change is small and is in StorageProxy.java and MessagingTask.java. I will submit
a patch shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message