cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10512) We do not save an upsampled index summaries
Date Wed, 02 Dec 2015 22:48:11 GMT


Ariel Weisberg commented on CASSANDRA-10512:

bq. The code changes look good to me, with only one nitpick: in MmappedSegmentedFile.copyReadableBounds(),
you used ii for the loop index variable instead of the standard i, for no reason that's apparent
to me.
I always use double letters for loop variables so you can search for them without hitting
the letters as they occur inside other words. If that conflicts with the code style for C*
I can go back to using single letter variables.

Will change it and rebase now.

> We do not save an upsampled index summaries
> -------------------------------------------
>                 Key: CASSANDRA-10512
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Benedict
>            Assignee: Ariel Weisberg
>             Fix For: 3.0.1, 3.1, 2.1.x, 2.2.x
> If we downsample an index summary, we overwrite the existing summary, despite downsampling
being inexpensive. However on upsampling (which is expensive) we do not, so that on restart
all of our index summaries are the smallest they have ever been adjusted to.

This message was sent by Atlassian JIRA

View raw message