cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremiah Jordan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10099) Improve concurrency in CompactionStrategyManager
Date Fri, 04 Dec 2015 20:09:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042146#comment-15042146
] 

Jeremiah Jordan commented on CASSANDRA-10099:
---------------------------------------------

second commit has compile errors.  Need to specify some types.

{noformat}
    [javac] /Users/jeremiah/github/riptano/cassandra/src/java/org/apache/cassandra/db/compaction/DateTieredCompactionStrategy.java:41:
error: method newSetFromMap in class Collections cannot be applied to given types;
    [javac]     private final Set<SSTableReader> sstables = Collections.newSetFromMap(new
ConcurrentHashMap<>());
    [javac]                                                            ^
    [javac]   required: Map<E,Boolean>
    [javac]   found: ConcurrentHashMap<Object,Object>
    [javac]   reason: no instance(s) of type variable(s) E exist so that argument type ConcurrentHashMap<Object,Object>
conforms to formal parameter type Map<E,Boolean>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in method <E>newSetFromMap(Map<E,Boolean>)
    [javac] /Users/jeremiah/github/riptano/cassandra/src/java/org/apache/cassandra/db/compaction/SizeTieredCompactionStrategy.java:65:
error: method newSetFromMap in class Collections cannot be applied to given types;
    [javac]     private final Set<SSTableReader> sstables = Collections.newSetFromMap(new
ConcurrentHashMap<>());
    [javac]                                                            ^
    [javac]   required: Map<E,Boolean>
    [javac]   found: ConcurrentHashMap<Object,Object>
    [javac]   reason: no instance(s) of type variable(s) E exist so that argument type ConcurrentHashMap<Object,Object>
conforms to formal parameter type Map<E,Boolean>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in method <E>newSetFromMap(Map<E,Boolean>)
{noformat}

> Improve concurrency in CompactionStrategyManager
> ------------------------------------------------
>
>                 Key: CASSANDRA-10099
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10099
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Yuki Morishita
>            Assignee: Marcus Eriksson
>             Fix For: 2.1.x, 2.2.x, 3.x
>
>
> Continue discussion from CASSANDRA-9882.
> CompactionStrategyManager(WrappingCompactionStrategy for <3.0) tracks SSTable changes
mainly for separating repaired / unrepaired SSTables (+ LCS manages level).
> This is blocking operation, and can lead to block of flush etc. when determining next
background task takes longer.
> Explore the way to mitigate this concurrency issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message