Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sun, 22 Nov 2015 13:22:10 +0000 (UTC)
From: "Robert Stupp (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12915155.1448198516000.151148.1448198530925@Atlassian.JIRA>
In-Reply-To: <JIRA.12915155.1448198516000@Atlassian.JIRA>
References: <JIRA.12915155.1448198516000@Atlassian.JIRA>
 <JIRA.12915155.1448198516528@arcas>
Subject: [jira] [Created] (CASSANDRA-10750) Minor code improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Robert Stupp created CASSANDRA-10750:
----------------------------------------

             Summary: Minor code improvements
                 Key: CASSANDRA-10750
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10750
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Robert Stupp
            Assignee: Robert Stupp
            Priority: Minor


Went though several IDE inspections and found some places in the code that could be improved. These are just minor improvements and no bug fixes (except one minor "theoretical" thing).

The [branch on github against trunk|https://github.com/snazy/cassandra/tree/10750-code-opts-trunk] contains a series of commits:

* simplify Mutation.apply to remove the casts
* "minor code improvements" just replaces some expressions that are effectively constant
* remove unused assignments (probably just cosmetic)
* collapse identical if-branches (probably just cosmetic)
* empty array constants
* fix printf usage (could potentially raise an exception in printf)
* replace tail-recursion in some critical sections (as the JVM cannot optimize that AFAIK)
* remove methods identical to their super methods (probably just cosmetic)

[cassci results here|http://cassci.datastax.com/view/Dev/view/snazy/search/?q=snazy-10750-]


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)