Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5687C17BA3 for ; Tue, 17 Nov 2015 12:19:11 +0000 (UTC) Received: (qmail 31349 invoked by uid 500); 17 Nov 2015 12:19:11 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 31294 invoked by uid 500); 17 Nov 2015 12:19:11 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 31254 invoked by uid 99); 17 Nov 2015 12:19:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 12:19:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F11872C1F51 for ; Tue, 17 Nov 2015 12:19:10 +0000 (UTC) Date: Tue, 17 Nov 2015 12:19:10 +0000 (UTC) From: "Mike Adamson (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10717) Changes from CASSANDRA-9353 makes Hadoop integration backward incompatible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-10717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008567#comment-15008567 ] Mike Adamson commented on CASSANDRA-10717: ------------------------------------------ [~jlewandowski] I'm not that fussed because in your patch, if the {{AuthProvider}} is set it will overwrite the {{PlainTextAuthProvider}} anyway. The change I was proposing was to make this clearer in the code, that if the user provided a username, password and {{AuthProvider}} then the provided {{AuthProvider}} took precedence over the {{PlainTextAuthProvider}}. > Changes from CASSANDRA-9353 makes Hadoop integration backward incompatible > -------------------------------------------------------------------------- > > Key: CASSANDRA-10717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10717 > Project: Cassandra > Issue Type: Bug > Reporter: Jacek Lewandowski > Assignee: Jacek Lewandowski > Attachments: CqlConfigHelper_authentication_patch.patch > > > Previously {{CqlInputFormat.getSplits(JobContext)}} method did not require anything but providing username and password in order to work with password protected Cassandra. Now, since CASSANDRA-9353 moved this part of the code from Thrift to Java Driver, the user needs to explicitly select {{AuthProvider}} to make it work. > I propose a simple change in {{CqlConfigHelper}} which make {{CqlConfigHelper.getCluster}} method set credentials on {{Cluster.Builder}} if they are present in the configuration, prior to setting {{AuthProvider}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)