Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 16 Nov 2015 16:41:11 +0000 (UTC)
From: "Joel Knighton (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12909737.1446488528000.81586.1447692071166@Atlassian.JIRA>
In-Reply-To: <JIRA.12909737.1446488528000@Atlassian.JIRA>
References: <JIRA.12909737.1446488528000@Atlassian.JIRA>
 <JIRA.12909737.1446488528359@arcas>
Subject: [jira] [Commented] (CASSANDRA-10632) sstableutil tests failing
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006896#comment-15006896 ] 

Joel Knighton commented on CASSANDRA-10632:
-------------------------------------------

I don't have an immediate reaction other than that I don't think there is a race condition in the cleanup there.

I'll take a look tonight.

> sstableutil tests failing
> -------------------------
>
>                 Key: CASSANDRA-10632
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jim Witschey
>            Assignee: Jim Witschey
>             Fix For: 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok, but string comparison fails when the leading {{d}} in the filename is lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}} test function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]), but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}} test function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive, including the drive portion? If that's the case, then we can just lowercase the file names in the test helper functions above when the tests are run on Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so. If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you find an assignee?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)