Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6A90118B50 for ; Mon, 9 Nov 2015 20:30:16 +0000 (UTC) Received: (qmail 89881 invoked by uid 500); 9 Nov 2015 20:30:11 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 89773 invoked by uid 500); 9 Nov 2015 20:30:11 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 89718 invoked by uid 99); 9 Nov 2015 20:30:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Nov 2015 20:30:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F1D792C1F56 for ; Mon, 9 Nov 2015 20:30:10 +0000 (UTC) Date: Mon, 9 Nov 2015 20:30:10 +0000 (UTC) From: "Aleksey Yeschenko (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10396) Simplify row cache invalidation code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997295#comment-14997295 ] Aleksey Yeschenko commented on CASSANDRA-10396: ----------------------------------------------- Patch LGTM. Committed to 2.2 and subsequently reverted, as I realised it doesn't belong to 2.2 (nor merges cleanly with 3.0). As it's a cleanup ticket, it should only go to 3.2 (which requires a different patch than this). If you still feel like getting this in, though, please retarget it for trunk (and don't forget to link to CI results). > Simplify row cache invalidation code > ------------------------------------ > > Key: CASSANDRA-10396 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10396 > Project: Cassandra > Issue Type: Task > Reporter: Jonathan Ellis > Assignee: Jonathan Ellis > Priority: Trivial > Fix For: 3.x > > > CFS.maybeUpdateRowCache and CFS.invalidateRowCache are nearly identical, except the latter does some unnecessary extra work looking up CFID. -- This message was sent by Atlassian JIRA (v6.3.4#6332)