cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Knighton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10754) Failure in QueryPagerTest.multiQueryTest due to assertion in SinglePartitionReadCommand$Group
Date Mon, 23 Nov 2015 23:48:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023380#comment-15023380
] 

Joel Knighton commented on CASSANDRA-10754:
-------------------------------------------

I've pushed a patch to 3.0 [here|https://github.com/jkni/cassandra/commits/10754-3.0].

I've changed all explicit references to {{nowInSeconds}} to a value generated once during
static initialization of the class.

I haven't run CI since this only affects unit tests; I induced the original flaky failure
by adding a sleep in command construction and confirmed that the above patch solves the issues.
 All other tests in the class still pass.

> Failure in QueryPagerTest.multiQueryTest due to assertion in SinglePartitionReadCommand$Group
> ---------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10754
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10754
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Joel Knighton
>            Assignee: Joel Knighton
>
> Test failure [here|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-9510-3.0-testall/lastCompletedBuild/testReport/org.apache.cassandra.service/QueryPagerTest/multiQueryTest/].
> It's on a 3.0 branch for a issue, but the patch only affects the implementation of the
{{assassinate}} command and wouldn't affect this unit test.
> The assertion failure is in the construction of a Group of SinglePartitionReadCommands,
where the value of {{nowInSec}} for each command does not match.
> I'm not sure if 1) this invariant isn't valuable, 2) this invariant is valuable but the
unit test does not accurately reflect how a group would be created, or 3) this is a genuine
bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message