cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Adamson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10717) Changes from CASSANDRA-9353 makes Hadoop integration backward incompatible
Date Tue, 17 Nov 2015 09:17:10 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008332#comment-15008332
] 

Mike Adamson commented on CASSANDRA-10717:
------------------------------------------

[~jlewandowski] Wouldn't it make more sense to have the check for the authProvider first and
then the username & password? Something like this:
{noformat}
if (authProvider.isPresent())
    builder.withAuthProvider(authProvider.get());
else if (username.isPresent() && password.isPresent())
    builder.withCredentials(username.get(), password.get());
{noformat}
This would allow for a user setting the username and password along with a non-standard auth
provider.


> Changes from CASSANDRA-9353 makes Hadoop integration backward incompatible
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10717
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10717
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jacek Lewandowski
>            Assignee: Jacek Lewandowski
>         Attachments: CqlConfigHelper_authentication_patch.patch
>
>
> Previously {{CqlInputFormat.getSplits(JobContext)}} method did not require anything but
providing username and password in order to work with password protected Cassandra. Now, since
CASSANDRA-9353 moved this part of the code from Thrift to Java Driver, the user needs to explicitly
select {{AuthProvider}} to make it work.
> I propose a simple change in {{CqlConfigHelper}} which make {{CqlConfigHelper.getCluster}}
method set credentials on {{Cluster.Builder}} if they are present in the configuration, prior
to setting {{AuthProvider}}. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message