cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10690) Secondary index does not process deletes unless columns are specified
Date Wed, 18 Nov 2015 08:27:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010462#comment-15010462
] 

Sylvain Lebresne commented on CASSANDRA-10690:
----------------------------------------------

bq. the Index interface is a somewhat public API

Meant to, but forgot to mention that. I'm not too fussed about breaking that API right now
cause it's brand new, 3.0 is so very new and adapting your custom index code to the change
is trivial. But yes, it's a breaking change strictly speaking and I'm totally fine only doing
that in 3.2 if we prefer. 

> Secondary index does not process deletes unless columns are specified
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-10690
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10690
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Tyler Hobbs
>             Fix For: 3.0.1, 3.1
>
>
> The new secondary index API does not notify indexes of single-row or slice deletions
unless specific columns are deleted.  I believe the problem is that in {{SecondaryIndexManager.newUpdateTransaction()}},
we skip indexes unless {{index.indexes(update.columns())}}.  When no columns are specified
in the the deletion, {{update.columns()}} is empty, which causes all indexes to be skipped.
> I think the correct fix is to do something like this in the {{ModificationStatement}}
constructor:
> {code}
> if (type == StatementType.DELETE && modifiedColumns.isEmpty())
>     modifiedColumns = cfm.partitionColumns();
> {code}
> However, I'm not sure if that may have unintended side-effects.  What do you think, [~slebresne]?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message