cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10678) add SSTable flush observer
Date Thu, 19 Nov 2015 10:59:12 GMT


Sam Tunnicliffe commented on CASSANDRA-10678:

The v2 patch looks good to me, modulo a couple of nits that can be addressed on commit.
* The entry in CHANGES.txt is appended to the list for 3.2, whereas lately the convention
has been to preprend (just to make subsequent merges easier). 
* The javadoc for {{SSTableFlushObserver::nextCell}} refers to the now-renamed {{startRow}}.

Related to the latter point: as I mentioned before, I suspect that when you come to add SASI
support for non-compact storage you're going to need some method on the observer to track
clusterings within a partition, but I'm fine with waiting until that's actually required before
adding that.

> add SSTable flush observer
> --------------------------
>                 Key: CASSANDRA-10678
>                 URL:
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Pavel Yaskevich
>            Assignee: Pavel Yaskevich
>             Fix For: 3.x
>         Attachments: 0001-Add-sstable-flush-observer.patch
> Add general interface which can intercept per SSTable flush events e.g. - start of the
key, columns etc. Make Index interface return such observer on request, which couples index
with corresponding SSTable file if needed.

This message was sent by Atlassian JIRA

View raw message