cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-10677) Improve performance of folderSize function
Date Mon, 16 Nov 2015 09:16:10 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-10677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sylvain Lebresne updated CASSANDRA-10677:
-----------------------------------------
         Priority: Minor  (was: Major)
         Reviewer: Stefania
    Fix Version/s:     (was: 2.1.x)
                   3.x

Thanks for the patch. Just a heads up however that we won't commit this on the 2.1 branch
due to its nature of a relatively minor (the {{folderSize}} method is not used in a critical
path) performance improvement. Marking 3.x accordingly.

> Improve performance of folderSize function
> ------------------------------------------
>
>                 Key: CASSANDRA-10677
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10677
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local Write-Read Paths
>         Environment: Ubuntu 14. JDK 7
>            Reporter: Briareus
>            Priority: Minor
>              Labels: patch, performance
>             Fix For: 3.x
>
>         Attachments: Optimized_folderSize_function_to_use_Java_7_nio_walkFileTree_method_.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> FileUtils.folderSize function recursively traverses the directory tree using listFiles
method. This is no longer efficient as Java 7 offers much better Files.walkFileTree method.
It makes the method work twice faster according to my tests. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message