cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10672) jacoco instrumentation breaks UDF validation
Date Sat, 07 Nov 2015 19:17:10 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995365#comment-14995365
] 

Robert Stupp commented on CASSANDRA-10672:
------------------------------------------

The general approach looks good to me. But do we need the {{List}} there? An {{int}} to
count the non-synthetic methods should work, too.
Question: do we need that just for trunk or also for 2.2 and 3.1?

> jacoco instrumentation breaks UDF validation
> --------------------------------------------
>
>                 Key: CASSANDRA-10672
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10672
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Russ Hatch
>            Assignee: Russ Hatch
>             Fix For: 3.2
>
>         Attachments: trunk-10672.txt
>
>
> The jacoco agent injects a synthetic method into UDF classes as part of instrumentation
for code coverage. Currently the UDF code checks the method count on java UDF classes, and
it fails due to the jacoco synthetic method increasing the method count.
> This causes a number of false test failures when running unit tests with jacoco instrumentation.
> A simple fix is just to ignore synthetic methods in the counting process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message