cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Witschey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10632) sstableutil tests failing
Date Mon, 16 Nov 2015 16:18:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006851#comment-15006851
] 

Jim Witschey commented on CASSANDRA-10632:
------------------------------------------

Here's the current status of these tests:

* Linux
** [{{compaction_test}} is fixed|http://cassci.datastax.com/job/cassandra-3.0_dtest/337/testReport/junit/sstableutil_test/SSTableUtilTest/compaction_test/history/].
** [{{abortedcompaction_test}} flaps|http://cassci.datastax.com/job/cassandra-3.0_dtest/337/testReport/junit/sstableutil_test/SSTableUtilTest/abortedcompaction_test/history/].
This could be because of a race condition in the test (as [noted in this comment|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L80])
and may be fixed by [this dtest PR|https://github.com/riptano/cassandra-dtest/pull/661].
* Windows
** [{{compaction_test}} is fixed|http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/112/testReport/junit/sstableutil_test/SSTableUtilTest/compaction_test/history/].
** [{{abortedcompaction_test}} fails consistently|http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/112/testReport/junit/sstableutil_test/SSTableUtilTest/abortedcompaction_test/history/].
It seems to fail when it finds temporary data files via {{sstableutil}} after compaction [in
this assertion|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L87].
Could this also be a race condition, where [the cleanup peformed in this line|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L85]
isn't complete?

[~jkni] I remember you saying you'd be willing/able to have a look at this. Do you have any
ideas about the failing Windows test?


> sstableutil tests failing
> -------------------------
>
>                 Key: CASSANDRA-10632
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jim Witschey
>            Assignee: Jim Witschey
>             Fix For: 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and {{sstableutil_test.py:SSTableUtilTest.compaction_test}}
fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok, but string
comparison fails when the leading {{d}} in the filename is lowercase as returned by {{sstableutil}}
(see the [{{_invoke_sstableutil}} test function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}} test function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive, including the
drive portion? If that's the case, then we can just lowercase the file names in the test helper
functions above when the tests are run on Windows. [~JoshuaMcKenzie] can you confirm? I'll
fix this in the tests if so. If I'm wrong, and something in {{sstableutil}} needs to be fixed,
could you find an assignee?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message