cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10632) sstableutil tests failing
Date Fri, 13 Nov 2015 14:00:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004009#comment-15004009
] 

Joshua McKenzie commented on CASSANDRA-10632:
---------------------------------------------

For temp files from an aborted compaction, I wouldn't expect them to hang around on Windows
after 3.0. Active sstables that are being read, maybe (since we mmap and have new retrying
deletion paths), but not temp sstables.

> sstableutil tests failing
> -------------------------
>
>                 Key: CASSANDRA-10632
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jim Witschey
>            Assignee: Jim Witschey
>             Fix For: 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and {{sstableutil_test.py:SSTableUtilTest.compaction_test}}
fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok, but string
comparison fails when the leading {{d}} in the filename is lowercase as returned by {{sstableutil}}
(see the [{{_invoke_sstableutil}} test function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}} test function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive, including the
drive portion? If that's the case, then we can just lowercase the file names in the test helper
functions above when the tests are run on Windows. [~JoshuaMcKenzie] can you confirm? I'll
fix this in the tests if so. If I'm wrong, and something in {{sstableutil}} needs to be fixed,
could you find an assignee?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message