cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10628) get JEMAlloc debug output out of nodetool output
Date Wed, 04 Nov 2015 20:19:28 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990322#comment-14990322
] 

Ariel Weisberg commented on CASSANDRA-10628:
--------------------------------------------

The change LGTM. The dtests and utests look good although the trunk version is still running.
I asked Robert to manually test on Linux and OS X, with and without jemalloc, and disabling
jemalloc with "-". If that checks out then +1.

> get JEMAlloc debug output out of nodetool output
> ------------------------------------------------
>
>                 Key: CASSANDRA-10628
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10628
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jim Witschey
>            Assignee: Robert Stupp
>             Fix For: 2.2.4, 3.0.0
>
>
> This is a followup ticket for CASSANDRA-10581. The consensus on the Cassandra TE is that
the debug output for loading JEMAlloc is helpful (or at least harmless when starting C*, but
not when starting {{nodetool}}, which, it turns out, sources {{cassandra-env}}:
> https://github.com/apache/cassandra/blob/trunk/bin/nodetool#L53
> You can reproduce the excessive output with
> {code}
> ccm create test-nodetool-output -v git:cassandra-3.0 -n 1 ; ccm start --wait-for-binary-proto
; ccm node1 nodetool ring
> {code}
> The simplest solution would probably be to redirect the output of the sourcing to {{/dev/null/}}.
I don't know if that's the right thing to do; it may be better to move the {{LD_PRELOAD}}-setting
logic to {{bin/cassandra}}. I'm not sure what the reasoning would be for putting something
in one place or another, so I leave it to the dev team to decide on the best solution.
> Assigning [~snazy] for now; feel free to reassign



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message