cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andre Turgeon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10358) Allow CQLSSTableWriter.Builder to use custom AbstractSSTableSimpleWriter
Date Tue, 03 Nov 2015 15:50:27 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987496#comment-14987496
] 

Andre Turgeon commented on CASSANDRA-10358:
-------------------------------------------

[~slebresne], I see your point. I was using the unsorted writer because it breaks up my stream
into roughly equally sized sstables. I could measure the stream myself and create a new {{CQLSSTablewriter}}
for each sstable I generate. 
That leaves me with the need to control the name of the sstable and its level. Have you had
a chance to look at {{SSTableWriterCreationStrategy}} idea? Could that be incorporated into
the code base?

> Allow CQLSSTableWriter.Builder to use custom AbstractSSTableSimpleWriter 
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10358
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10358
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Andre Turgeon
>            Priority: Minor
>         Attachments: SSTableWriterCreationStrategy.patch, patch.txt
>
>
> I've created a patch for your consideration. 
> This change to CQLSSTableWriter allows for a custom AbstractSSTableSimpleWriter to be
specified. 
> I needed this for a bulkload process I wrote. I believe the change would be beneficial
for other people as well. 
> Below are the reasons I needed a custom implementation of AbstractSSTableSimpleWriter:
> 1) The available implementations of AbstractSSTableSimpleWriter do not provide a way
to specify the filename (or rather revision) of the sstable. I needed to control the name
because my bulkload process write sstables in parallel (on multiple machines) and I wish to
avoid name collisions.
> 2) I discovered a problem with SSTableSimpleUnsortedWriter where it creates invalid level-compaction-style
sstables; It allows a partition to span 2 sstables which violates the "no overlap of token
ranges" constraint of level compaction.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message