cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10243) Warn or fail when changing cluster topology live
Date Mon, 23 Nov 2015 21:11:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023072#comment-15023072
] 

Paulo Motta commented on CASSANDRA-10243:
-----------------------------------------

Looking good, a few nits left:
* It's not very common to update snitch property of a live node (specially with GPFS), so
I don't think the warning is necessary. Should we maybe add a note to NEWS.txt instead? Or
maybe print the warn on 2.1/2.2, and remove it on 3.0?
* On CASSANDRA-9474 we changed the property name from {{override_rackdc}} to the original
{{ignore_rack}} in addition to {{ignore_dc}}, could you please fix dtests?
* Instead of manipulating gossip {{EndpointState}} in {{StorageProxy.truncateBlocking()}},
what do you think about adding a excludeNodesInDeadState option to {{StorageService.getLiveMembers}}
and {{Gossiper.getLiveMembers}} (which you could also rename it to {{Gossiper.getLiveEndpoints}})?
* Please fix [nodetool_test.TestNodetool.test_correct_dc_rack_in_nodetool_info|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10243-2.2-dtest/lastCompletedBuild/testReport/nodetool_test/TestNodetool/test_correct_dc_rack_in_nodetool_info/]
dtest
* It seems [3.1 dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-10243-3.1-dtest/]
did not run, mind resubmitting please?

Thanks!

> Warn or fail when changing cluster topology live
> ------------------------------------------------
>
>                 Key: CASSANDRA-10243
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10243
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Stefania
>            Priority: Critical
>             Fix For: 2.1.x
>
>
> Moving a node from one rack to another in the snitch, while it is alive, is almost always
the wrong thing to do.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message