cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Branimir Lambov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9991) Implement efficient btree removal
Date Mon, 30 Nov 2015 09:32:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031543#comment-15031543
] 

Branimir Lambov commented on CASSANDRA-9991:
--------------------------------------------

The code looks good overall, but please remove the unused {{BTree.isLeaf}} and rename and
document {{BTree.swap}} as explained above.

Nit: repeating the walk from the root to {{node}} and the child to the left of the element
in finding {{elementToSwap}} appears completely unnecessary.

> Implement efficient btree removal
> ---------------------------------
>
>                 Key: CASSANDRA-9991
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9991
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Benedict
>              Labels: patch
>             Fix For: 3.x
>
>         Attachments: trunk-9991-v3.txt, trunk-9991-v4.txt, trunk-9991.txt, trunk-9991.txt-v2
>
>
> Currently removal is implemented as a reconstruction by filtering and iterator over the
original btree. This could be much more efficient, editing just the necessary nodes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message