cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Resolved] (CASSANDRA-9477) nodetool repair should exit with non-zero status on failure
Date Fri, 20 Nov 2015 12:39:11 GMT


Sylvain Lebresne resolved CASSANDRA-9477.
    Resolution: Duplicate

Was about to commit but turns out this have been fixed by CASSANDRA-9569 already (with exactly
the same fix).

> nodetool repair should exit with non-zero status on failure
> -----------------------------------------------------------
>                 Key: CASSANDRA-9477
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Randy Fradin
>            Assignee: Clément Lardeur
>            Priority: Minor
>             Fix For: 2.1.x
>         Attachments: cassandra-2.1-9477.patch
> Previously nodetool repair would exit with a non-zero status code when it experienced
an error (like in CASSANDRA-5203), e.g. due a neighbor being down or a failed stream. It appears
this is no longer the case, which makes it a bit harder to automate repair. I suspect it's
been this way since CASSANDRA-6381 was implemented, and that it probably affects other nodetool
commands as well.
> It looks like NodeProbe tracks when a failure occurs and this is accessible via NodeProbe.isFailed(),
but that value is not being used anywhere. I think the problem could be fixed inside,
if after the execute function is called, probe.isFailed() is checked and a RuntimeException
is thrown if a failure has occurred.

This message was sent by Atlassian JIRA

View raw message