cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9302) Optimize cqlsh COPY FROM, part 3
Date Wed, 25 Nov 2015 03:58:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026131#comment-15026131
] 

Stefania commented on CASSANDRA-9302:
-------------------------------------

I've rebased and added support for counters now that CASSANDRA-9043 has been committed. I
did not use prepared statements for counters.

Note for merging 2.2 to 3.0: even if there are no conflicts we need the following change due
to the driver API differences:

{code}
diff --git a/pylib/cqlshlib/copy.py b/pylib/cqlshlib/copy.py
index 8bfda32..963245f 100644
--- a/pylib/cqlshlib/copy.py
+++ b/pylib/cqlshlib/copy.py
@@ -1067,7 +1067,7 @@ class ImportProcess(ChildProcess):
         try:
             session = self.get_session()
             table_meta = session.cluster.metadata.keyspaces[self.ks].tables[self.cf]
-            is_counter = ("counter" in [table_meta.columns[name].typestring for name in self.columns])
+            is_counter = ("counter" in [table_meta.columns[name] for name in self.columns])

             if is_counter:
                 self.run_counter(session, table_meta)
{code}

> Optimize cqlsh COPY FROM, part 3
> --------------------------------
>
>                 Key: CASSANDRA-9302
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9302
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Stefania
>            Priority: Critical
>             Fix For: 2.1.x
>
>
> We've had some discussion moving to Spark CSV import for bulk load in 3.x, but people
need a good bulk load tool now.  One option is to add a separate Java bulk load tool (CASSANDRA-9048),
but if we can match that performance from cqlsh I would prefer to leave COPY FROM as the preferred
option to which we point people, rather than adding more tools that need to be supported indefinitely.
> Previous work on COPY FROM optimization was done in CASSANDRA-7405 and CASSANDRA-8225.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message