cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Eriksson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
Date Mon, 16 Nov 2015 09:32:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006393#comment-15006393
] 

Marcus Eriksson commented on CASSANDRA-8805:
--------------------------------------------

Patch looks good to me, but in the new test, could we verify that the tracker has the correct
sstable instances? (ie, just verify that the finally clause in adjustSamplingLevels actually
does the right thing). Also perhaps validate the data in StandardLowIndexInterval after compaction
cancellation?

> runWithCompactionsDisabled only cancels compactions, which is not the only source of
markCompacted
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8805
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8805
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Benedict
>            Assignee: Carl Yeksigian
>             Fix For: 2.1.x
>
>         Attachments: 8805-2.1.txt
>
>
> Operations like repair that may operate over all sstables cancel compactions before beginning,
and fail if there are any files marked compacting after doing so. Redistribution of index
summaries is not a compaction, so is not cancelled by this action, but does mark sstables
as compacting, so such an action will fail to initiate if there is an index summary redistribution
in progress. It seems that IndexSummaryManager needs to register itself as interruptible along
with compactions (AFAICT no other actions that may markCompacting are not themselves compactions).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message