Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 26 Oct 2015 10:20:27 +0000 (UTC)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12907158.1445536277000.57526.1445854827735@Atlassian.JIRA>
In-Reply-To: <JIRA.12907158.1445536277000@Atlassian.JIRA>
References: <JIRA.12907158.1445536277000@Atlassian.JIRA>
 <JIRA.12907158.1445536277547@arcas>
Subject: [jira] [Commented] (CASSANDRA-10572)
 SinglePartitionNamesCommand::canRemoveRow omits counter cells it shouldn't
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CASSANDRA-10572?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D14973983#comment-14973983 ]=20

Sylvain Lebresne commented on CASSANDRA-10572:
----------------------------------------------

I've pushed a patch [here|https://github.com/pcmanus/cassandra/commits/1057=
2].

A very trivial fix for this would be to exclude counters like we exclude co=
llections in {{SinglePartitionNamesCommand::canRemoveRow}}. However, the re=
ality is that it's particularly judicious to use the timestamp-ordered path=
 for either of those (collections or counters), since we'd be guaranteed to=
 read all sstable anyway and so reading sstable sequentially (materializing=
 everything in memory) is not the best strategy. So the best strategy is pr=
obably to have counters and collections use the non timestamp ordered path.=
 Doing so however kind of obviate the reason for splitting {{SinglePartitio=
nReadCommand}} in 2 subclass (names and slice comands), so the patch remove=
 that. Basically, it pulls the 2 possible path (timestamp-orderer and all-s=
stables-simultaneously) in {{SinglePartitionReadCommand}} and pick the time=
stamp-ordered one only for names query without either counters or collectio=
ns. As such, the patch is bigger that one would expect, but that's mostly b=
ecause it moves some code around and update the code accordingly.

> SinglePartitionNamesCommand::canRemoveRow omits counter cells it shouldn'=
t
> -------------------------------------------------------------------------=
-
>
>                 Key: CASSANDRA-10572
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1057=
2
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Sylvain Lebresne
>             Fix For: 3.0.0
>
>
> Like with collections, we can never be sure we've exhausted all the sstab=
les when reducing the filter. The sstables can contain legacy local shards =
that need to be summed up. Unless we look into the content of the cells (?)=
, or until we get rid of the pre-2.1 values, we must include all the sstabl=
es in the read (so long as clusterings overlap).
> This was not an issue with 2.1/2.2 as we've forced {{collectAllData}} alw=
ays on that path, but now we don't, and {{SinglePartitionNamesCommand}} sho=
uld handle the case.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)