Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 30 Oct 2015 19:55:28 +0000 (UTC)
From: "Aleksey Yeschenko (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12907149.1445535482000.111566.1446234928002@Atlassian.JIRA>
In-Reply-To: <JIRA.12907149.1445535482000@Atlassian.JIRA>
References: <JIRA.12907149.1445535482000@Atlassian.JIRA>
 <JIRA.12907149.1445535482405@arcas>
Subject: [jira] [Commented] (CASSANDRA-10571)
 ClusteringIndexNamesFilter::shouldInclude is not implemented,
 SinglePartitionNamesCommand not discarding the sstables it could
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983185#comment-14983185 ] 

Aleksey Yeschenko commented on CASSANDRA-10571:
-----------------------------------------------

+1

> ClusteringIndexNamesFilter::shouldInclude is not implemented, SinglePartitionNamesCommand not discarding the sstables it could
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10571
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10571
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Sylvain Lebresne
>             Fix For: 3.0.0
>
>
> Now that we use {{SinglePartitionNamesCommand}} in more places - where we'd previously use what is now {{SinglePartitionSliceCommand}} - not being able to skip sstables with non-overlapping clusterings is actually a performance regression.
> {{SinglePartitionNamesCommand::queryMemtableAndDiskInternal}} should prune sstables based on {{ClusteringIndexNamesFilter::shouldInclude}} output, and the latter must be replaced with an actual implementation instead of a {{TODO}}.
> This is also a potentially a big regression in performance for counter writes (say, with DTCS), since before 3.0, the read-before-write code would use {{collectAllData}}, and that *was* pruning sstable with non-overlapping clusterings.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)