Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 14 Oct 2015 23:42:06 +0000 (UTC)
From: "Stefania (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12905019.1444858604000.42997.1444866126225@Atlassian.JIRA>
In-Reply-To: <JIRA.12905019.1444858604000@Atlassian.JIRA>
References: <JIRA.12905019.1444858604000@Atlassian.JIRA>
 <JIRA.12905019.1444858604622@arcas>
Subject: [jira] [Commented] (CASSANDRA-10529) Channel.size() is costly,
 mutually exclusive, and on the critical path
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958021#comment-14958021 ] 

Stefania commented on CASSANDRA-10529:
--------------------------------------

I mentioned it in the first bullet point of [this comment|https://issues.apache.org/jira/browse/CASSANDRA-10407?focusedCommentId=14943083&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14943083] on CASSANDRA-10407.

> Channel.size() is costly, mutually exclusive, and on the critical path
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-10529
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10529
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>             Fix For: 3.0.0 rc2
>
>
> [~stefania_alborghetti] mentioned this already on another ticket, but I have lost track of exactly where. While benchmarking it became apparent this was a noticeable bottleneck for small in-memory workloads with few files, especially with RF=1. We should probably fix this soon, since it is trivial to do so, and the call is only to impose an assertion that our requested length is less than the file size. It isn't possible to safely memoize a value anywhere we can guarantee to be able to safely refer to it without some refactoring, so I suggest simply removing the assertion for now.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)