Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A074718806 for ; Wed, 14 Oct 2015 16:05:06 +0000 (UTC) Received: (qmail 64743 invoked by uid 500); 14 Oct 2015 16:05:06 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 64670 invoked by uid 500); 14 Oct 2015 16:05:06 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 64656 invoked by uid 99); 14 Oct 2015 16:05:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Oct 2015 16:05:06 +0000 Date: Wed, 14 Oct 2015 16:05:06 +0000 (UTC) From: "Yuki Morishita (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10522) counter upgrade dtest fails on 3.0 with JVM assertions disabled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957145#comment-14957145 ] Yuki Morishita commented on CASSANDRA-10522: -------------------------------------------- This is because {{Matcher#matches}} is called inside assertion. We need to call it outside. patch here: https://github.com/yukim/cassandra/commits/10552 > counter upgrade dtest fails on 3.0 with JVM assertions disabled > --------------------------------------------------------------- > > Key: CASSANDRA-10522 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10522 > Project: Cassandra > Issue Type: Sub-task > Reporter: Andrew Hust > Fix For: 3.0.0 rc2 > > > {{counter_tests.TestCounters.upgrade_test}} > will fail when run on a cluster with JVM assertions disabled. The tests will hang when cassandra throws the following exception: > {code} > java.lang.IllegalStateException: No match found > at java.util.regex.Matcher.group(Matcher.java:536) ~[na:1.8.0_60] > at org.apache.cassandra.db.lifecycle.LogFile.make(LogFile.java:52) ~[main/:na] > at org.apache.cassandra.db.lifecycle.LogTransaction.removeUnfinishedLeftovers(LogTransaction.java:399) ~[main/:na] > at org.apache.cassandra.db.lifecycle.LifecycleTransaction.removeUnfinishedLeftovers(LifecycleTransaction.java:552) ~[main/:na] > at org.apache.cassandra.db.ColumnFamilyStore.scrubDataDirectories(ColumnFamilyStore.java:571) ~[main/:na] > at org.apache.cassandra.service.StartupChecks$7.execute(StartupChecks.java:274) ~[main/:na] > at org.apache.cassandra.service.StartupChecks.verify(StartupChecks.java:103) ~[main/:na] > at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:169) [main/:na] > at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:548) [main/:na] > at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:676) [main/:na] > {code} > These tests both pass with/without JVM assertions on C* 2.2 and pass on 3.0 when assertions are enabled. > Ran against: > apache/cassandra-2.2: {{7cab3272455bdd16b639c510416ae339a8613414}} > apache/cassandra-3.0: {{f21c888510b0dbbea1a63459476f2dc54093de63}} > Ran with cmd: > {{JVM_EXTRA_OPTS=-da PRINT_DEBUG=true nosetests -xsv counter_tests.TestCounters.upgrade_test}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)