cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Lerer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10606) AbstractBTreePartition.rowCount() return the wrong number of rows for compact tables
Date Wed, 28 Oct 2015 08:47:27 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977978#comment-14977978
] 

Benjamin Lerer commented on CASSANDRA-10606:
--------------------------------------------

{quote}Why do you think this is a problem btw?{quote}
My code is checking if a {{ColumnFamilyStore}} is empty or not using the {{isEmpty()}} method.
This method internally rely on {{Memtable.getOperation()}} to determine if an existing memtable
is empty or not. This number is incremented in {{Memtable.put}} by {{PartitionUpdate.operationCount()}}
which in the case of compact table return 0 even if some static columns are set.

I am not sure that this patch is proper the way to fix the problem but I believe that something
is currently broken in {{PartitionUpdate}} as it should return a non zero value if it contains
an operation that change only the value of a static column.  

> AbstractBTreePartition.rowCount() return the wrong number of rows for compact tables
> ------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10606
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10606
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>             Fix For: 3.0.0
>
>         Attachments: 10606-3.0.txt
>
>
> For compact tables {{AbstractBTreePartition.rowCount()}} return the wrong number of columns
as it does not take into account static rows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message