cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10576) Thrift CAS on static columns doesn't work as expected
Date Wed, 28 Oct 2015 15:40:27 GMT


Sylvain Lebresne commented on CASSANDRA-10576:


Nit: in {{ThriftCasRequest}}, there is 2 places where we do {{if (expected == null || expected.isEmpty())}}:
we can ditch the {{expected == null}} now. 

> Thrift CAS on static columns doesn't work as expected
> -----------------------------------------------------
>                 Key: CASSANDRA-10576
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>             Fix For: 3.0.0
> Although the thrift cas call works as expected for dynamic column families, using it
on tables with statically defined columns produces unexpected results. The problem, in {{ThriftCASRequest}},
is that while the {{expected}} partition contains a static row, the {{current}} partition
has been processed by {{ThriftResultsMerger}} during the read, converting the static columns
to clusterings. If {{expected}} contains only a static row, no further checking is carried
out, {{appliesTo}} erroneously returns true and the conditional update is performed regardless
of the current state of the partition.

This message was sent by Atlassian JIRA

View raw message